Thanks for the update on this . Do you plan to push it today or tomorrow ?
Best regards, Matthias > -----Original Message----- > From: Prasanta Sadhukhan <prasanta.sadhuk...@oracle.com> > Sent: Dienstag, 26. November 2019 10:26 > To: Baesken, Matthias <matthias.baes...@sap.com>; Erik Joelsson > <erik.joels...@oracle.com>; 'build-dev@openjdk.java.net' <build- > d...@openjdk.java.net> > Cc: 2d-...@openjdk.java.net; Lindenmaier, Goetz > <goetz.lindenma...@sap.com> > Subject: Re: RFR [XS]: 8234795: ix build fails on macOS lower than 10.13 after > 8214578 was: build fails on macOS 10.12 after 8214578: [macos] Problem with > backslashes on macOS/JIS keyboard: Java ignores system settings > > I have already raised a similar fix sometime back for JDK-8234786 > > Regards > > Prasanta > > On 26-Nov-19 2:49 PM, Baesken, Matthias wrote: > > Hello, here is a small adjustment that uses the typealias for > NSTextInputSourceIdentifier . This fixes the build on macOS < 10.13 . > > > > > > Bug/webrev : > > > > https://bugs.openjdk.java.net/browse/JDK-8234795 > > > > > > http://cr.openjdk.java.net/~mbaesken/webrevs/8234795.0/ > > > > > > Thanks, Matthias > > > > > >> If there is a simple fix, I would very much like to see it done. I'm not > >> familiar enough with this area to know what the implications would be > >> though. > >> > >> /Erik > >> > >> On 2019-11-25 04:48, Baesken, Matthias wrote: > >>> Hello, any comments on the issue ? > >>> > >>> Could we maybe switch from using > >>> > >>> NSTextInputSourceIdentifier > >>> > >>> to > >>> > >>> String (NSString* ?) , because > >> > https://developer.apple.com/documentation/appkit/nstextinputsourceiden > >> tifier > >>> says NSTextInputSourceIdentifier is a typealias for String ? > >>> > >>> Best regards ,Matthias > >>> > >>> > >>> > >>> > >>> Hello, I noticed that since today our jdk/jdk build fails on macOS . We > run > >> it on macOS 10.12 . > >>> It seems > >>> https://hg.openjdk.java.net/jdk/jdk/rev/d0bfaae2ff33 > >>> > >>> 8214578: [macos] Problem with backslashes on macOS/JIS keyboard: > Java > >> ignores system settings > >>> Brought a dependency on 10.13. Was that intended ? Could we keep > 10.12 > >> compatibility ? > >>> At least the doc of NSTextInputSourceIdentifier : > >> > https://developer.apple.com/documentation/appkit/nstextinputsourceiden > >> tifier > >>> mentions macOS 10.13+ . > >>> > >>> > >>> > >>> Build errors are : > >>> ---------------------------- > >>> > >>> > /jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.h:41:5: > >> error: unknown type name 'NSTextInputSourceIdentifier' > >>> NSTextInputSourceIdentifier kbdLayout; > >>> ^ > >>> > >> > /jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m:93:23: > >> error: assignment to readonly property > >>> self.cglLayer = windowLayer; > >>> ~~~~~~~~~~~~~ ^ ~~~~~~~~~~~ > >>> > >> > /jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.m:110:1 > >> 9: error: assignment to readonly property > >>> self.cglLayer = nil; > >>> ~~~~~~~~~~~~~ ^ ~~~ > >>> 3 errors generated. > >>> > >>> > >>> ... > >>> > >> > /jdk/src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.m:45 > >> 4:18: error: incompatible pointer to integer conversion initializing 'BOOL' > (aka > >> 'signed char') with an expression of type 'id' [-Werror,-Wint-conversion] > >>> BOOL mouseIsOver = [[window contentView] mouseIsOver]; > >>> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > >>> 2 errors generated. > >>> > >>> > >>> > >>> Best regards, Matthias
