> > Hello , please review the downport of "8234525: enable link-time section- > gc for linux s390x to remove unused code" to jdk11 . > > > > My change from jdk/jdk did not apply directly and I had to adjust it > > slightly . > > > > > > > > > > Bug and jdk/jdk change : > > > > https://bugs.openjdk.java.net/browse/JDK-8234525 > > https://hg.openjdk.java.net/jdk/jdk/rev/c04fa10636fd > > > > > > Adjusted change for jdk11u-dev : > > > > http://cr.openjdk.java.net/~mbaesken/webrevs/8234525.0_jdk11/ > > > > > > Original review thread : > > > > https://mail.openjdk.java.net/pipermail/build-dev/2019- > November/026326.html > > > > > > Thanks, Matthias > > > > In the original patch, the lines are added after > TOOLCHAIN_CFLAGS_JDK_CONLY. In the 11u version, they seem to have > needlessly moved above it. > > Otherwise, looks good. > > Regarding the patch itself, are these flags only useful when the s390x > port is present or would they be advantageous on older versions where > s390x is still using the Zero assembler port? >
Hello Andrew, thanks for the review . I did not check the zero based ports . However as long as gcc and ld support the flags used , it should work with zero too . Best regards, Matthias