Yes.
/Erik
On 2020-03-13 23:09, jiefu(傅杰) wrote:
Thanks Mikael for your review.
Is it OK to be pushed?
Best regards,
Jie
On 2020/3/14, 12:45 PM, "Mikael Vidstedt" <mikael.vidst...@oracle.com> wrote:
Looks good. I also noticed this and filed JDK-8241035[1], but closed my issue as a duplicate of yours.
Cheers,
Mikael
[1] https://bugs.openjdk.java.net/browse/JDK-8241035
> On Mar 13, 2020, at 5:13 PM, jiefu(傅杰) <ji...@tencent.com> wrote:
>
> Hi all,
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8241034
> Webrev: http://cr.openjdk.java.net/~jiefu/8241034/webrev.00/
>
> A shell command error was observed during the jdk configuration.
> ```
> jdk/build/.configure-support/generated-configure.sh: line 91505:
-Xmx2048M: command not found
> ```
> To find out the error message, you can just grep "line 91505: -Xmx2048M:
command not found" in the configure.log file.
>
> It might be better to fix it.
>
> Testing:
> - Configuring and building these configurations on macos
> * macosx-x86_64-server-fastdebug
> * macosx-x86_64-server-release
> * macosx-x86_64-minimal-release
> * macosx-x86_64-zero-release
>
> Please review it and give me some advice.
>
> Thanks a lot.
> Best regards,
> Jie
