From a build perspective this looks fine.
But it seems you are changing the interface for java.lang.System. Don't
you need a CSR for that? Or is your claim that the interface was indeed
changed by JDK-8197927, and it is a bug that the documentation was not
updated to match this?
/Magnus
On 2020-03-31 16:56, Langer, Christoph wrote:
Hi,
please review a small fix that updates two comments.
The first one, in make/autoconf/spec.gmk.in, is probably quite old. It talks about handling of a property
"vm.vendor" in VersionProps.java.template. However, there is no property "vm.vendor", it
must rather be "java.vendor". I stumbled over that when looking at the change of JDK-4947890
(Minimize JNI upcalls in system-properties initialization).
The second one is the code comment attached to "private static Properties props;" in
java.lang.System. After JDK-8197927 (Allow the system property `java.vendor.version` to be
undefined), "java.vendor.version" can be undefined, so this should be reflected in the
comment. I also took the liberty to remove an unneeded import statement.
Bug: https://bugs.openjdk.java.net/browse/JDK-8241947
Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8241947.0/
Thanks
Christoph
