Hello,
I could reproduce this and found the issue. There is a typo in the
conditional. Posting review.
/Erik
On 2020-04-30 10:43, Florian Weimer wrote:
* Magnus Ihse Bursie:
On 2020-04-30 15:50, Florian Weimer wrote:
* Magnus Ihse Bursie:
I made sure that no build performances were measured on my system, and
since I saw no such indication, I did not make any more systematic analysis.
What is the difference if you run with or without the javac server?
Thanks. Which configure flags do you want me to test?
Four measurements:
Prior to JDK-8244036: configure with --enable-javac-server and
--disable-javac-server, and "make jdk-image"
--enable-javac-server: 174s
--disable-javac-server: 241s
After JDK-8244036: configure with --enable-javac-server and
--disable-javac-server, and "make jdk-image"
--enable-javac-server: 247s
--disable-javac-server: 249s
If any of them show major differences with and without JDK-8244036, you
can try running that option for more granular targets, e.g. "jdk".
jdk times before: ~161s (--enable-javac-server), 231s (--disable-javac-server)
jdk times after: 237s (both cases)
It looks like the server is not running anymore.
The build log difference seems to be this.
Before:
( /bin/rm -f
/mnt/scratch1/fw/jdk/buildtools/jdk_tools_classes/_the.BUILD_TOOLS_JDK_batch.log
&& /usr/lib/jvm/java-14-openjdk-amd64/bin/java -XX:+UseSerialGC
-Xms32M -Xmx512M -XX:TieredStopAtLevel=1 -Duser.language=en
-Duser.country=US -XX:+UnlockDiagnosticVMOptions
-XX:-VerifySharedSpaces
-XX:SharedArchiveFile=/mnt/scratch1/fw/jdk/configure-support/classes.jsa
-Xshare:auto --limit-modules
java.base,jdk.zipfs,java.compiler.interim,jdk.compiler.interim,jdk.javadoc.interim
--add-modules
java.compiler.interim,jdk.compiler.interim,jdk.javadoc.interim
--module-path
/mnt/scratch1/fw/jdk/buildtools/interim_langtools_modules
--add-exports java.base/sun.reflect.annotation=jdk.compiler.interim
--add-exports java.base/jdk.internal.jmod=jdk.compiler.interim
--add-exports java.base/jdk.internal.misc=jdk.compiler.interim -m
jdk.compiler.interim/com.sun.tools.sjavac.Main
--server:portfile=/mnt/scratch1/fw/jdk/make-support/javacservers/server.port,id=BUILD_TOOLS_JDK,sjavac=/usr/lib/jvm/java-14-openjdk-amd64/bin/java%20-Xms512M%20-Xmx2048M%20--limit-modules%20java.base%2Cjdk.zipfs%2Cjava.compiler.interim%2Cjdk.compiler.interim%2Cjdk.javadoc.interim%20--add-modules%20java.compiler.interim%2Cjdk.compiler.interim%2Cjdk.javadoc.interim%20--module-path%20/mnt/scratch1/fw/jdk/buildtools/interim_langtools_modules%20--add-exports%20java.base/sun.reflect.annotation=jdk.compiler.interim%20--add-exports%20java.base/jdk.internal.jmod=jdk.compiler.interim%20--add-exports%20java.base/jdk.internal.misc=jdk.compiler.interim%20-m%20jdk.compiler.interim/com.sun.tools.sjavac.Main
-g -source 14 -target 14 -XDignore.symbol.file=true
-XDstringConcat=inline -Xlint:all -Werror -Xlint:-options
--add-exports java.desktop/sun.awt=ALL-UNNAMED --add-exports
java.base/sun.text=ALL-UNNAMED -implicit:none -d
/mnt/scratch1/fw/jdk/buildtools/jdk_tools_classes
@/mnt/scratch1/fw/jdk/buildtools/jdk_tools_classes/_the.BUILD_TOOLS_JDK_batch.tmp
> >(/usr/bin/tee -a
/mnt/scratch1/fw/jdk/buildtools/jdk_tools_classes/_the.BUILD_TOOLS_JDK_batch.log)
2> >(/usr/bin/tee -a
/mnt/scratch1/fw/jdk/buildtools/jdk_tools_classes/_the.BUILD_TOOLS_JDK_batch.log
>&2) || ( exitcode=$? && /bin/cp
/mnt/scratch1/fw/jdk/buildtools/jdk_tools_classes/_the.BUILD_TOOLS_JDK_batch.log
/mnt/scratch1/fw/jdk/make-support/failure-logs/buildtools_jdk_tools_classes__the.BUILD_TOOLS_JDK_batch.log
&& /bin/cp
/mnt/scratch1/fw/jdk/buildtools/jdk_tools_classes/_the.BUILD_TOOLS_JDK_batch.cmdline
/mnt/scratch1/fw/jdk/make-support/failure-logs/buildtools_jdk_tools_classes__the.BUILD_TOOLS_JDK_batch.cmdline
&& exit $exitcode ) ) && /bin/mv
/mnt/scratch1/fw/jdk/buildtools/jdk_tools_classes/_the.BUILD_TOOLS_JDK_batch.tmp
/mnt/scratch1/fw/jdk/buildtools/jdk_tools_classes/_the.BUILD_TOOLS_JDK_batch
After:
( /bin/rm -f
/mnt/scratch1/fw/jdk/buildtools/jdk_tools_classes/_the.BUILD_TOOLS_JDK_batch.log
&& /usr/lib/jvm/java-14-openjdk-amd64/bin/java -XX:+UseSerialGC
-Xms32M -Xmx512M -XX:TieredStopAtLevel=1 -Duser.language=en
-Duser.country=US -XX:+UnlockDiagnosticVMOptions
-XX:-VerifySharedSpaces
-XX:SharedArchiveFile=/mnt/scratch1/fw/jdk/configure-support/classes.jsa
-Xshare:auto --limit-modules
java.base,jdk.zipfs,java.compiler.interim,jdk.compiler.interim,jdk.javadoc.interim
--add-modules
java.compiler.interim,jdk.compiler.interim,jdk.javadoc.interim
--module-path
/mnt/scratch1/fw/jdk/buildtools/interim_langtools_modules
--add-exports java.base/sun.reflect.annotation=jdk.compiler.interim
--add-exports java.base/jdk.internal.jmod=jdk.compiler.interim
--add-exports java.base/jdk.internal.misc=jdk.compiler.interim -m
jdk.compiler.interim/com.sun.tools.javac.Main -g -Xlint:all
--doclint-format html5 -source 14 -target 14 -implicit:none
-Xprefer:source -XDignore.symbol.file=true -encoding ascii -Werror
--add-exports java.desktop/sun.awt=ALL-UNNAMED --add-exports
java.base/sun.text=ALL-UNNAMED -Xlint:-options -d
/mnt/scratch1/fw/jdk/buildtools/jdk_tools_classes
@/mnt/scratch1/fw/jdk/buildtools/jdk_tools_classes/_the.BUILD_TOOLS_JDK_batch.tmp
> >(/usr/bin/tee -a
/mnt/scratch1/fw/jdk/buildtools/jdk_tools_classes/_the.BUILD_TOOLS_JDK_batch.log)
2> >(/usr/bin/tee -a
/mnt/scratch1/fw/jdk/buildtools/jdk_tools_classes/_the.BUILD_TOOLS_JDK_batch.log
>&2) || ( exitcode=$? && /bin/cp
/mnt/scratch1/fw/jdk/buildtools/jdk_tools_classes/_the.BUILD_TOOLS_JDK_batch.log
/mnt/scratch1/fw/jdk/make-support/failure-logs/buildtools_jdk_tools_classes__the.BUILD_TOOLS_JDK_batch.log
&& /bin/cp
/mnt/scratch1/fw/jdk/buildtools/jdk_tools_classes/_the.BUILD_TOOLS_JDK_batch.cmdline
/mnt/scratch1/fw/jdk/make-support/failure-logs/buildtools_jdk_tools_classes__the.BUILD_TOOLS_JDK_batch.cmdline
&& exit $exitcode ) ) && /bin/mv
/mnt/scratch1/fw/jdk/buildtools/jdk_tools_classes/_the.BUILD_TOOLS_JDK_batch.tmp
/mnt/scratch1/fw/jdk/buildtools/jdk_tools_classes/_the.BUILD_TOOLS_JDK_batch
So the --server argument is gone.
Any suggestions how to debug this further? The configure log does not
show anything.
