Erik:

Looks good.

Tim

After the sjavac cleanup in JDK-8244036 (and the subsequent fix of the javac server usage in JDK-8244210), two more build failures have been noted. The bootcycle build fails and the test-make target fails the tests of SetupJavaCompilation.

The bootcycle build fails because a space has crept into the variable SJAVAC_SERVER_DIR when it's overridden in bootcycle-spec.gmk.in This space splits the sjavac server argument.

The tests for make just need to be updated to use the new TARGET_RELEASE arg instead of the old SetupJavaCompiler construct.

Bug: https://bugs.openjdk.java.net/browse/JDK-8244247

Webrev: http://cr.openjdk.java.net/~erikj/8244247/webrev.01/index.html

/Erik


Reply via email to