On 2020-05-04 01:38, Kim Barrett wrote:
On May 4, 2020, at 1:12 AM, Mikael Vidstedt <mikael.vidst...@oracle.com> wrote:
Please review this change which implements part of JEP 381:
JBS: https://bugs.openjdk.java.net/browse/JDK-8244224
webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.00/build/open/webrev/
JEP: https://bugs.openjdk.java.net/browse/JDK-8241787
Looks good to me.
One comment:
------------------------------------------------------------------------------
build/open/webrev/make/autoconf/libraries.m4
107 if test "x$TOOLCHAIN_TYPE" = xsolstudio; then
108 GLOBAL_LIBS="-lc"
109 else
110 GLOBAL_LIBS=""
111 fi
=>
106 GLOBAL_LIBS=""
With this change, GLOBAL_LIBS appears to never have a non-empty value.
Maybe it's no longer needed at all.
That is true, that variable was introduced explicitly for the Solaris
Studio compiler.
/Erik
