On Tue, 2020-05-05 at 08:24 -0700, Erik Joelsson wrote: > Looks good to me.
Thanks for the review, Erik! Cheers, Severin > /Erik > > On 2020-05-05 08:15, Severin Gehwolf wrote: > > Hi, > > > > Could I please get a review of this trivial change? Apparently using > > the help builtin for determining whether or not a builtin is available > > is not a good idea. A more portable way to do this is to use "command > > -v" or "type". Thanks to Michael Zucchi for contributing this fix. > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8243656 > > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8243656/02/webrev/ > > > > Testing: Local builds. jdk/submit. > > > > Thoughts? > > > > Thanks, > > Severin > >