Magnus,
Thanks! I will push.
Yumin
On 5/16/20 12:35 AM, Magnus Ihse Bursie wrote:
On 2020-05-16 00:57, Yumin Qi wrote:
Hi, Erik
Thanks for test/review.
On 5/15/20 1:48 PM, Erik Joelsson wrote:
I tried a variant of this patch with a 32 bit intel build (server
only to get the cds archive generation enabled). It makes the build
work as expected.
The conditions on line 120 and 125 are unnecessary and just add
clutter IMO. Otherwise good.
Just don't want to have not-useful variables defined. I will remove
them.
Your patch at
http://cr.openjdk.java.net/~minqi/2020/8245070/webrev-00/jdk.patch, as
it currently looks, is now identical to my patch, which Marc has
confirmed solves the problem on arm32. So it looks good now.
/Magnus
Thanks
Yumin
/Erik
On 2020-05-15 11:29, Yumin Qi wrote:
Magnus,
Thanks. Let's wait for the result of your patch.
I updated my webrev as your suggestion.
Thanks
Yumin
On 5/15/20 11:19 AM, Magnus Ihse Bursie wrote:
On 2020-05-15 19:49, Yumin Qi wrote:
Hi,
Please review the xsmall change for
bug: 8245070: https://bugs.openjdk.java.net/browse/JDK-8245070
webrev: http://cr.openjdk.java.net/~minqi/2020/8245070/webrev-00/
The change of 8245070 broke build for 32 bits, since no
compressed oops on 32 bits. Guard the change for 64 bits only.
I could not build 32 bits --- have no 32 bit platform to make
sure of the change, so please give a detail look. The variable
OPENJDK_TARGET_CPU_BITS is copied from other file.
Hi Yumin,
I have already suggested a patch along these line in
https://mail.openjdk.java.net/pipermail/build-dev/2020-May/027469.html.
I am still awaiting confirmation from Marc that it solves his
problem.
Regarding your patch, the contemporary style of checking target
bits is "ifeq ($(call isTargetCpuBits, 64), true))", rather than
"ifeq ($(OPENJDK_TARGET_CPU_BITS), 64)".
/Magnus
Thanks
Yumin
