Erik, David, thank you for your reviews, pushed.
Cheers, -- Igor > On Jun 9, 2020, at 7:06 PM, David Holmes <david.hol...@oracle.com> wrote: > > Hi Igor, > > All of these changes seem okay to me. > > Thanks, > David > On Jun 9, 2020, at 9:10 AM, Erik Joelsson <erik.joels...@oracle.com> wrote: > > Looks good to me. > > /Erik > > On 10/06/2020 1:56 am, Igor Ignatyev wrote: >> http://cr.openjdk.java.net/~iignatyev/8246387/webrev.00/ >>> 110 lines changed: 6 ins; 89 del; 15 mod; >> Hi all, >> could you please review the patch which switches jtreg used in jdk/jdk to >> the newly promoted jtreg5.1? as before, the patch changes 'requiredVersion' >> property in all jtreg test suites to have more consistent results. >> besides changing the version in jib-profiles and requiredVersion in all >> TEST.ROOT, the patch also >> - removes no-op methods from GatherDiagnosticInfoObserver. in jtharness >> 6.0-b11, and Harness.Observer::finishedTesting() method got deprecated, but >> instead of suppressing the warning, we can just remove it and other empty >> methods as Harness.Observer interface now provides no-op implementations for >> all its methods; >> - removes j.t.lib.Utils::getTestName method. this method has a (now) wrong >> assumption that testng classes are available only if we are executing a >> testng test. the method was used only by appcds tests to get a test specific >> filename, and these tests were updated to use a new supported way to get a >> testname via `test.name` system property; >> - updates >> test/hotspot/jtreg/runtime/condy/staticInit/TestInitException.java test to >> workaround CODETOOLS-7902686[1] . jasm from asmtools 7.0-b08 incorrectly >> sets full file path on windows as SourceFile, so the test was temporarily >> updated to use regexp which matches both full path and just basename. >> webrev: http://cr.openjdk.java.net/~iignatyev/8246387/webrev.00/ >> testing: tier1-4 >> JBS: https://bugs.openjdk.java.net/browse/JDK-8246387 >> [1] https://bugs.openjdk.java.net/browse/CODETOOLS-7902686 >> (fixed in asmtools7.0-b09, yet jtreg5.1 uses asmtools7.0-b08, so effectively >> can be fixed only w/ switch to a next version of jtreg) >> Thanks, >> -- Igor
