On Wed, 30 Sep 2020 18:19:53 GMT, Paul Sandoz <psan...@openjdk.org> wrote:
>> Hi @PaulSandoz , >> >> This integration seems to miss >> https://github.com/openjdk/panama-vector/pull/1, which had fixed crashes on >> AVX512 >> machines. >> Thanks. > > @DamonFool we can follow up later for that fix (and others in > `vectorIntrinsics`), after this PR integrates. I don't > want to perturb the code that has already been reviewed, which requires yet > more additional review. Hi @PaulSandoz , I think it would be better to integrate it [1] in this MR. I have tested this MR on our AVX512 machines and it still crashes. Also, for the sake of maintenance, it seems NOT a good idea to push a problematic commit into the jdk main-line repo. As for the review process, I don't think it's a problem since the fix [1] is clear and small enough. What do you think? Thanks. [1] https://github.com/openjdk/panama-vector/commit/1af35c357066743935bd3f48ce3610a41761f89a ------------- PR: https://git.openjdk.java.net/jdk/pull/367
