> This patch is reorganized after 8252725, which is separated from this patch 
> to refactor jlink glugin code. The previous
> webrev with hg can be found at: 
> http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-05. With 8252725 
> integrated, the
> regeneration of holder classes is simply to call the new added 
> GenerateJLIClassesHelper.cdsGenerateHolderClasses
> function.  Tests: tier1-4

Yumin Qi has updated the pull request incrementally with one additional commit 
since the last revision:

  Made isDumpingClassList a private final and add a public function to access 
it. Changed function validateInputLines to
  isValidInputLines and return a boolean to indicate its valid. Added more 
comments for review concern.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/193/files
  - new: https://git.openjdk.java.net/jdk/pull/193/files/107192f3..f163fe4c

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=193&range=13
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=193&range=12-13

  Stats: 28 lines in 2 files changed: 9 ins; 6 del; 13 mod
  Patch: https://git.openjdk.java.net/jdk/pull/193.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/193/head:pull/193

PR: https://git.openjdk.java.net/jdk/pull/193

Reply via email to