On Tue, 13 Oct 2020 13:44:22 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Andy Herrick has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JDK-8252870: Finalize (remove "incubator" from) jpackage
>> - reverting two auto-generated files, and changing module-info to
>> "@since 16"
>
> make/data/symbols/jdk.jpackage-E.sym.txt line 29:
>
>> 27: # ##########################################################
>> 28: #
>> 29: module name jdk.jpackage
>
> I think you need to revert this. Note this comment:
>
> # ### THIS FILE IS AUTOMATICALLY GENERATED. DO NOT EDIT. ###
reverted
> make/data/symbols/symbols line 40:
>
>> 38: platform version C base B files
>> java.base-C.sym.txt:java.compiler-C.sym.txt:java.desktop-C.sym.txt:java.naming-C.sym.txt:java.rmi-C.sym.txt:java.xml-C.sym.txt:jdk.compiler-C.sym.txt:jdk.jfr-C.sym.txt:jdk.jsobject-C.sym.txt:jdk.unsupported-C.sym.txt
>> 39: platform version D base C files
>> java.base-D.sym.txt:java.compiler-D.sym.txt:java.desktop-D.sym.txt:java.management-D.sym.txt:java.management.rmi-D.sym.txt:java.net.http-D.sym.txt:java.security.jgss-D.sym.txt:java.xml-D.sym.txt:java.xml.crypto-D.sym.txt:jdk.compiler-D.sym.txt:jdk.httpserver-D.sym.txt:jdk.jartool-D.sym.txt:jdk.javadoc-D.sym.txt:jdk.jlink-D.sym.txt:jdk.jshell-D.sym.txt
>> 40: platform version E base D files
>> java.base-E.sym.txt:java.compiler-E.sym.txt:java.desktop-E.sym.txt:java.xml-E.sym.txt:jdk.compiler-E.sym.txt:jdk.httpserver-E.sym.txt:jdk.incubator.foreign-E.sym.txt:jdk.jpackage-E.sym.txt:jdk.jfr-E.sym.txt:jdk.jlink-E.sym.txt:jdk.jshell-E.sym.txt:jdk.jsobject-E.sym.txt:jdk.management-E.sym.txt:jdk.net-E.sym.txt:jdk.pack-E.sym.txt
>
> Similarly, I think you need to revert this.
reverted
> src/jdk.jpackage/share/classes/module-info.java line 49:
>
>> 47: */
>> 48:
>> 49: module jdk.jpackage {
>
> Change to `@since 16`
changed to @since16
-------------
PR: https://git.openjdk.java.net/jdk/pull/633
