On Fri, 25 Sep 2020 20:35:32 GMT, Erik Joelsson <er...@openjdk.org> wrote:

> In AotCompiler.java, if artifact resolution fails, we have no way of 
> diagnosing the error. This patch improves the
> default toString() of ArtifactResolverException to automatically include the 
> toString() method of the root cause. It
> also adds stack trace printing specifically in AotCompiler.java.   I also 
> found a similar issue in PKCS11Test, and
> fixed it by adding the ArtifactResolverException there as cause for the 
> RuntimeException being thrown. This causes the
> stack trace to be printed on failure.  I looked through all other uses of 
> ArtifactResolver, but they are handling the
> exception in a way that already prints the stack trace.

Looks good to me.

-------------

Marked as reviewed by ihse (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/368

Reply via email to