Sorry for being late on this one (I'm working through a huge backlog), but it does not seem like the removal was complete.

ENABLE_INTREE_EC is still present in spec.gmk. And it is still checked in modules/jdk.crypto.ec/Lib.gmk. In fact, this entire file should be removed.

Anthony, can you please open a new JBS issue to fix the remaining cleanup?

/Magnus

On 2020-09-22 15:23, Erik Joelsson wrote:
On Tue, 22 Sep 2020 00:18:07 GMT, Anthony Scarpino <ascarp...@openjdk.org> 
wrote:

This change removes the native elliptic curves library code; as well as, and 
calls to that code, tests, and files
associated with those libraries.  The makefiles have been changed to remove 
from all source builds of the ec code.  The
SunEC system property is removed and java.security configurations changed to 
reflect the removed curves.  This will
remove the following elliptic curves from SunEC:   secp112r1, secp112r2, 
secp128r1, secp128r2, secp160k1, secp160r1,
secp160r2, secp192k1, secp192r1, secp224k1, secp224r1, secp256k1, sect113r1, 
sect113r2, sect131r1, sect131r2,
sect163k1, sect163r1, sect163r2, sect193r1, sect193r2, sect233k1, sect233r1, 
sect239k1, sect283k1, sect283r1,
sect409k1, sect409r1, sect571k1, sect571r1, X9.62 c2tnb191v1, X9.62 c2tnb191v2, 
X9.62 c2tnb191v3, X9.62 c2tnb239v1,
X9.62 c2tnb239v2, X9.62 c2tnb239v3, X9.62 c2tnb359v1, X9.62 c2tnb431r1, X9.62 
prime192v2, X9.62 prime192v3, X9.62
prime239v1, X9.62 prime239v2, X9.62 prime239v3, brainpoolP256r1 
brainpoolP320r1, brainpoolP384r1, brainpoolP512r1
Anthony Scarpino has updated the pull request incrementally with one additional 
commit since the last revision:

   remove JDKOPT_DETECT_INTREE_EC from configure.ac
Build changes look good.

Marked as reviewed by erikj (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/289

Reply via email to