On Mon, 2 Nov 2020 16:16:25 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> @magicus I did test the initial version of this PR on linux+arm64, but not >> the latest iteration. sorry about that 🙁 >> >> What is the policy here? Submit a revert right away or investigate a fix? > > @lewurm Open a new JBS issue with the bug. If you can find a fix in a short > amount of time (which I would believe should be possible; probably just need > a proper cast) it's acceptable to fix it directly. What amounts to a "short > amount of time" is left to reasonable judgement; minutes to hours are okay, > days are not. > > Otherwise, create an anti-delta (revert changeset) to back out your changes, > and open yet another JBS issue for re-implementing them correctly. > > In this case, an alternative short-term fix could also be to remove the > assert instead of backing out the entire patch. https://github.com/openjdk/jdk/pull/1013 ------------- PR: https://git.openjdk.java.net/jdk/pull/530
