On Mon, 9 Nov 2020 12:07:37 GMT, Jie Fu <[email protected]> wrote: > Hi all, > > The gitignore setting for netbeans project seems to be incomplete. > Only nbproject/private/ [1] is ignored. > > But there are also other files under nbproject/, which should be ignored too. > ---------------------------- > $ tree -L 1 nbproject/ > nbproject/ > ├── configurations.xml > ├── private > └── project.xml > ---------------------------- > > It would be better to fix it. > > Thanks. > Best regards, > Jie > > > [1] https://github.com/openjdk/jdk/blob/master/.gitignore#L5
.gitignore line 5: > 3: /.idea/ > 4: /.vscode/ > 5: /nbproject/ I believe the existing nbproject/private/ is meant to catch any private files created by someone opening any of the various nbproject directories that exist in the source base, so it should probably stay. Adding an ignore for any top level nbproject directory in addition to that should be ok. ------------- PR: https://git.openjdk.java.net/jdk/pull/1122
