On Wed, 11 Nov 2020 21:02:38 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> Aleksey Shipilev has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commits since the last revision: >> >> - Merge branch 'master' into JDK-8256127-foreign-build >> - Merge branch 'master' into JDK-8256127-foreign-build >> - Incomplete fix: remove special dirs >> - Merge branch 'master' into JDK-8256127-foreign-build >> - Remove special directories from chroot to make it archivable >> - 8256127: Add cross-compiled foreign architectures builds to submit >> workflow > > Aleksey, > > I'm not at all sure I want to accept these changes. I understand that you > care about these exotic platforms, and so do I, but adding them to the submit > workflow for *all* changes seem like the wrong way to proceed. > > My concern vary all the way from increased build time, to increased usage of > the Github CPU quota (which, as I understand it, is fairly large but not > unlimited), to the elephant in the room: the question on who the burden lays > to fix bugs in these exotic platforms. It is not at all obvious that these > builds should be tested before commit. > > I think this change warrants a much wider and deeper discussion about the > purpose of the Github commit hook actions, how the free Github CPU quota > should be spent, and on whom the responsibility lays to either make sure no. > commit is pushed that breaks an exotic platform, or to rectify the problem > with a follow-up issue. > > I recommend you withdraw this PR and instead initiate a wider discussion on a > suitable mailing list, e.g. jdk-dev. Maybe it would be possible to build hotspot only as this is the part where things often break? This would save a lot of CPU time. E.g. I think it'd be valueable to have at least one Big Endian platform included. I noticed that some Oracle people use cross builds to check their changes on these platforms. It would save a bit of their time as well. ------------- PR: https://git.openjdk.java.net/jdk/pull/1147
