On Tue, 15 Dec 2020 16:53:46 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> The hard-coded list of modules in `make/common/Modules.gmk` has always been >> a wart in the build system. We pride ourself on using discovery instead of >> hard-coded list. In this case, it is not possible to do do auto-discovery, >> since the different module sets are configured, not determined. >> >> Thus the actual lists of module sets should move to the `make/conf` >> directory. >> >> This is the first patch in a series where I will move configuration values >> spread over the build system into the designated `make/conf` directory. > > I really dislike patch as it mixes up several things in module-sets.conf. If > you really need to move configuration out of Modules.gmk (and I see no reason > to do this) then please look at separating out the static mapping of modules > to class loaders, the modules used for the interim builds, and the modules > used to create API docs. @AlanBateman It's not really more mixed-up than it was previously in Modules.gmk, since I lifted the code mostly unchanged from there. But sure, I can split it up further; I agree that it might make sense to do so. ------------- PR: https://git.openjdk.java.net/jdk/pull/1781
