On Thu, 24 Dec 2020 13:27:33 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
> I think the two issues described here are distinct and should be dealt > with in separate bugs and PRs. Their only relation is that both arise > with using clang-10. But they are very different problems, in very > different parts of the code, and probably ought to be reviewed by > folks from different teams. Thanks for your comment. Warning message of '-Wimplicit-int-float-conversion' was further encountered after we fixed the build failure caused by '-Wdeprecated-copy' first. That's why we put them in one PR initially. Yes. Your way is much better. But we suppose the issue of '-Wimplicit-int-float-conversion' is trivial and putting them in separate PRs might raise another internal review process (for our side) by which extra time is needed. I was wondering could we continue in one single PR. :) ------------- PR: https://git.openjdk.java.net/jdk/pull/1874
