On 9/01/2021 11:33 pm, Yasumasa Suenaga wrote:
On Sat, 9 Jan 2021 09:21:20 GMT, David Holmes <dhol...@openjdk.org> wrote:
Yasumasa Suenaga has updated the pull request incrementally with one additional
commit since the last revision:
Refactoring
make/scripts/fixpath.sh line 155:
153: if [[ $? -ne 0 ]]; then
154: unixpath="$unixpath.exe"
155: winpath="$($PATHTOOL -w "$path.exe" 2>/dev/null)"
I think it would be a little cleaner/clearer to use unixpath on line 155.
We will check the result from `$PATHTOOL` at L154, so I think current location
is fine.
I'm not at all sure what you mean by the reference to PATHTOOL here, so
to be clear I was suggesting writing line 155 as:
winpath="$($PATHTOOL -w "$unixpath" 2>/dev/null)"
David
-------------
PR: https://git.openjdk.java.net/jdk/pull/1889
