On Sat, 27 Feb 2021 05:42:16 GMT, Yumin Qi <mi...@openjdk.org> wrote:
>> Hi, Please review >> Usually most OSes are configured with page size of 4K, but some others are >> configured with 64K. If jdk binary is built on 4K platform and run on >> different configured platforms, CDS fails to be loaded due to region >> alignment mismatch: >> Unable to map CDS archive -- os::vm_allocation_granularity() expected: >> 4096 actual: 65536 >> This change uses 64K as region alignment if OS page size is less than 64K. >> For most of the current OSes, means always use 64K as file map region >> alignment. >> The archive size will increase about 300K due to the change. >> Tests: tier1-4 >> Run MacOS/X64 binary on MacOS/aarch64 >> >> Thanks >> Yumin > > Yumin Qi has updated the pull request incrementally with one additional > commit since the last revision: > > Add --enable-compatible-cds-alignment for linux-aarch64 and macosx-x64 in > jib job Build changes look ok to me. ------------- Marked as reviewed by erikj (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/2651
