On Tue, 9 Mar 2021 20:16:25 GMT, Alexey Ushakov <a...@openjdk.org> wrote:
>> src/java.desktop/macosx/classes/sun/java2d/metal/MTLBlitLoops.java line 499: >> >>> 497: } >>> 498: >>> 499: // We can convert argb_pre data from MTL surface in two places: >> >> Does anybody check that this is true for the metal pipeline? or It is just >> copied from the OGL? > > I fixed some conversion logic within JDK-8256331. OK, just to confirm. I wrote that text for OGL because it was the fastest way to transfer+convert the data from the video card to the memory. And as far as I understand the metal has the same limitation? It is not possible to convert it to some non-ARGB/Pre format on the fly while transferring the pixles? >> src/java.desktop/macosx/classes/sun/java2d/metal/MTLSurfaceData.java line >> 146: >> >>> 144: return MTLSurfaceRTT; >>> 145: default: >>> 146: return MTLSurface; >> >> Do we really support 3 different types of surface? I guess only two of them >> are different: textures used for manageable images, and surfaces used by the >> volatile image. > > It's true but I don't see any problem returning a more generic type as a > default here tbd ------------- PR: https://git.openjdk.java.net/jdk/pull/2403
