On Mon, 15 Mar 2021 18:35:12 GMT, Phil Race <p...@openjdk.org> wrote:
>> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux > >> Just thinking out loud, you don't think it would be better to build harfbuzz >> separately, but as a static library, that is then included in >> libfontmanager? The main win of doing that, I think, is the ability to have >> all the disabled warnings confined to the lower-quality upstream source. The >> resulting code would be the same. And from a build performance perspective I >> don't think any way of doing it matters. > > I don't know that this would be worth such an effort. I've clearly separated > the warnings we are disabling for HARFBUZZ and there's really not a lot of > likelihood in my mind that these warnings will suddenly also start to apply > to the small amount of JDK code that is in libfontmanager which is also much > simpler code. > > BTW I noticed we are still disabling all warnings for sunFont.c and after > this is done I'll likely see if I can make a source code change to resolve > that. I was actually thinking that such a change would be simpler; more or less amounting to changing from LIBRARY to STATIC_LIBRARY. But if you feel that it is too much work, fine... ------------- PR: https://git.openjdk.java.net/jdk/pull/2982
