On Tue, 30 Mar 2021 15:03:29 GMT, Anton Kozlov <akoz...@openjdk.org> wrote:
> Please review a change that adds cross-compiled macos/aarch64 platform build > into Github Actions test workflow. > > The steps are basically copy-paste of macos/x86-64 build with the necessary > platform name adjustments. A default XCode is also used, as macos/aarch64 > build requires XCode 12+. > > I've checked the produced build (can be found in > https://github.com/AntonKozlov/jdk/actions/runs/667527036), it starts on the > actual aarch64 machine. Even if what you currently want is the "latest" Xcode, I still think the choice should be explicit on the version. Otherwise we will suddenly get a new version picked at some random time in the future, which may not work. It's very important to control as many external variables as possible when defining a verification build like this. .github/workflows/submit.yml line 1444: > 1442: --with-conf-name=macos-aarch64 > 1443: --openjdk-target=aarch64-apple-darwin > 1444: --with-extra-cflags="-arch arm64" If configure isn't adding these flags automatically, that's something that we should fix. ------------- PR: https://git.openjdk.java.net/jdk/pull/3270
