On Wed, 7 Apr 2021 16:09:22 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Conor Cleary has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8264779: Simplified comments > > src/java.base/share/classes/java/nio/charset/MalformedInputException.java > line 45: > >> 43: >> 44: /** >> 45: * The length of the input byte sequence. > > Should this comment also refer to the character sequence? It could, maybe something like "The length of the input byte (or character) sequence." would work? > src/java.base/share/classes/java/nio/exceptions line 31: > >> 29: PACKAGE=java.nio >> 30: # This year should only change if the generated source is modified. >> 31: COPYRIGHT_YEARS="2000, 2021," > > Does not seem necessary, as I don't see any changes in java.nio package. This makes changes to the copyright headers of of the generated source files `UnsupportedCharsetException.java` and `IllegalCharsetNameException.java`. These can be found under a jdk build in `support/gensrc` and the headers update after running `make jdk-image`. Perhaps the build is out of date? These changes are harder to track as the source is not checked in. ------------- PR: https://git.openjdk.java.net/jdk/pull/3376