On Wed, 6 Jan 2021 06:16:43 GMT, Hao Sun <hao...@openjdk.org> wrote:

> Making the conversion explicit would fix it.
> 
> Flag '-Wimplicit-int-float-conversion' is first introduced in clang-10.
> Therefore clang-8 and clang-9 are not affected. The flag with similar
> functionality in gcc is '-Wfloat-conversion', but it is not enabled by
> '-Wall' or '-Wextra'. That's why this warning does not appear when
> building with gcc.
> 
> 
> Note that we have tested with this patch, debug build succeeded with clang-10 
> on Linux X86-64/AArch64 machines.
> Note that '--with-extra-cxxflags=-Wno-deprecated-copy' should be added when 
> configuration. It's another issue (See JDK-8258010)

This pull request has now been integrated.

Changeset: 28c35aed
Author:    Hao Sun <hao...@openjdk.org>
Committer: David Holmes <dhol...@openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/28c35aed
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

8259288: Debug build failure with clang-10 due to 
-Wimplicit-int-float-conversion

Reviewed-by: dholmes

-------------

PR: https://git.openjdk.java.net/jdk/pull/1956

Reply via email to