On Thu, 6 May 2021 06:58:16 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
>> Harfbuzz upgrade broke Linux x64 build on older gccs. For details see JBS >> issue. >> >> I fixed the issue in the harfbuzz sources, but I am not sure of the policy >> here. Do we modify the harfbuzz sources or leave them untouched? Advice is >> welcome. >> >> The patch fixes linux x64 fastdebug and opt build for me. > > Thomas Stuefe has updated the pull request incrementally with one additional > commit since the last revision: > > switch off warning in build instead of fixing it Looks good to me, thanks! Personally I'm building with gcc 9. I've test your fix successfully with gcc 7.5. Cheers, Richard. ------------- Marked as reviewed by rrich (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/3873