On Tue, 18 May 2021 03:35:11 GMT, Jie Fu <ji...@openjdk.org> wrote: >> Hi all, >> >> vmTestbase/vm/mlvm/anonloader/stress/oome/metaspace/Test.java fails on our >> many-core machines due to `-XX:MaxRAMPercentage=0`. >> This is because `MaxRAMPercentage` will be always 0 if JTREG_JOBS > 25 [1]. >> >> It can be reproduced by: `make test >> TEST="vmTestbase/vm/mlvm/anonloader/stress/oome/metaspace/Test.java" >> JTREG="JOBS=26"` on almost all machines. >> >> Setting `-XX:MaxRAMPercentage=0` on many-core machines seems unreasonable. >> It would be better to fix it. >> >> Thanks. >> Best regards, >> Jie >> >> >> [1] https://github.com/openjdk/jdk/blob/master/make/RunTests.gmk#L741 > > Jie Fu has updated the pull request incrementally with one additional commit > since the last revision: > > Use awk to compute MaxRAMPercentage
I am good with this change, but someone else should take a look as well. I ran `tier1` and `tier2` on my 3970X, which usually runs with `-XX:MaxRAMPercentage=0` due to having 32 cores, and the tests completed fine. It now runs with `-XX:MaxRAMPercentage=0.78125`. ------------- Marked as reviewed by shade (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4062
