On Fri, 25 Jun 2021 01:15:29 GMT, Yumin Qi <mi...@openjdk.org> wrote:
>> Hi, Please review >> systemDictionaryShared becomes fatter and fatter so it is time to split it >> into functional files. Moved security and jar operation related code into >> CDSProtectionDomain, and moved shared class info (DumpTime/RunTime) to >> sharedClassInfo.[ch]pp, also moved lambda proxy related to >> lambdaProxyClassInfo.hpp. This way systemDictionaryShared.cpp looks neat and >> light. >> >> Tests: tier1,tier3,tier4 >> >> Thanks >> Yumin > > Yumin Qi has updated the pull request incrementally with one additional > commit since the last revision: > > Remove 'Shared' from class names and rename corresponding files This looks OK to me. The naming of the various classes is still not consistent since the code has evolved for a long time. It was probably a mistake to add `Shared` as a classname suffix, but that was done since the beginning of CDS. Maybe eventually we should rename all the classes with a CDS prefix (similar to the JFR code). That should be done in a separate PR, though. ------------- Marked as reviewed by iklam (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4568
