On Wed, 7 Jul 2021 19:02:04 GMT, Erik Joelsson <er...@openjdk.org> wrote:
> This patch adds copying of element-list files generated for jdk.javadoc to > the interim langtools version of jdk.javadoc. I'm also refactoring the > jdk.javadoc/Gendata.gmk file a bit to better adhere to current build infra > standards as this was missed in the original review of this file. Rebuilding > should now work better with the various clean targets and any problems with > the generation tool will be captured in separate log files, along with the > command lines. > > @hns Can you verify that this solves the problem you reported? Generally, looks good. Thanks for the general cleanup to prevailing standards. The work looks OK, but I don't consider myself a build-Reviewer. Note to self: it might be interesting to figure out exactly how we might routinely test this feature. make/modules/jdk.javadoc/Gendata.gmk line 86: > 84: 11 \ > 85: ) > 86: # Generate element-list file for the current JDK version Is this indentation as intended? ------------- Marked as reviewed by jjg (Reviewer). PR: https://git.openjdk.java.net/jdk17/pull/227
