On Fri, 27 Aug 2021 23:12:52 GMT, Ioi Lam <ik...@openjdk.org> wrote:

> When the classlist is generated using build.tools.classlist.HelloClasslist, 
> its contents may be non-deterministic due to Java thread execution order.
> 
> We should sort the generated classlist to make the JDK image's contents more 
> deterministic.
> 
> Tested with Mach5 tier1, tier2, builds-tier5

make/jdk/src/classes/build/tools/classlist/SortClasslist.java line 58:

> 56:             String line = scanner.nextLine();
> 57:             Matcher m = p.matcher(line);
> 58:             if (m.find()) {

Are we sure that a comment line will not match this regexp, or that if it 
matches, it is not a comment line?

-------------

PR: https://git.openjdk.java.net/jdk/pull/5288

Reply via email to