On Thu, 22 Jul 2021 16:43:26 GMT, Severin Gehwolf <sgehw...@openjdk.org> wrote:

> Hi!
> 
> Please review this tiny patch which removes the special casing of 
> `--with-native-debug-symbols=external` for the static libs build. I don't see 
> why this is needed. If no debug symbols are wanted 
> `--with-native-debug-symbols=none` can be used to achieve the same effect. 
> Therefore, I propose to remove this hunk.
> 
> Testing: Inspecting of the log files and seeing that `-g` switch is there. 
> Run the reproducer test on the resulting static libraries.
> 
> Thoughts?

The use case we'd be needing for this is to have debug info in the static 
libraries, but not in the dynamic variants. The reason for this is that in 
order for somebody to get debug symbols for a binary that includes some OpenJDK 
static libs **and** want relevant debug info for the OpenJDK libs, stripping 
needs to happen after the final binary has been linked. As such, external debug 
symbols for static libs aren't as useful. Therefore, implementing stripping for 
static libs has fairly low priority for me. For the time being I'll withdraw 
this PR.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4876

Reply via email to