On Thu, 7 Oct 2021 08:27:47 GMT, Niklas Radomski <nradom...@openjdk.org> wrote:
>> Port the Z garbage collector >> ([JDK-8209683](https://bugs.openjdk.java.net/browse/JDK-8209683)) to linux >> on ppc64le. > > Niklas Radomski has updated the pull request incrementally with two > additional commits since the last revision: > > - Update autoconf error message > - Remove copyright headers Nice contribution! Thanks for doing the changes I had requested during my offline review. New version needs a few minor fixes, but looks great in general. src/hotspot/cpu/ppc/ppc.ad line 8142: > 8140: match(Set res (CompareAndExchangeP mem_ptr (Binary src1 src2))); > 8141: predicate((((CompareAndSwapNode*)n)->order() != MemNode::acquire && > ((CompareAndSwapNode*)n)->order() != MemNode::seqcst) > 8142: && n->as_Load()->barrier_data() == 0); Needs to be `as_LoadStore()`. src/hotspot/cpu/ppc/ppc.ad line 8157: > 8155: match(Set res (CompareAndExchangeP mem_ptr (Binary src1 src2))); > 8156: predicate((((CompareAndSwapNode*)n)->order() == MemNode::acquire || > ((CompareAndSwapNode*)n)->order() == MemNode::seqcst) > 8157: && n->as_Load()->barrier_data() == 0); Needs to be `as_LoadStore()`. src/hotspot/cpu/ppc/ppc.ad line 8379: > 8377: instruct getAndSetP(iRegPdst res, iRegPdst mem_ptr, iRegPsrc src, > flagsRegCR0 cr0) %{ > 8378: match(Set res (GetAndSetP mem_ptr src)); > 8379: predicate(n->as_Load()->barrier_data() == 0); Needs to be `as_LoadStore()`. ------------- Changes requested by mdoerr (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/5842
