On Wed, 20 Oct 2021 00:10:14 GMT, Erik Joelsson <[email protected]> wrote:
>> Please review this small change that adds the linux-aarch64 zero build
>> profile.
>
> make/autoconf/lib-ffi.m4 line 152:
>
>> 150: AC_MSG_ERROR([Could not locate libffi.so.? for bundling])
>> 151: fi
>> 152: elif ((test "x${OPENJDK_TARGET_CPU}" = "xx86_64") || (test
>> "x${OPENJDK_TARGET_CPU}" = "xaarch64")); then
>
> Using parens like this in shell isn't wrong, but it's not a pattern we
> commonly use in these files.
I might add that each layer of () spawns a new subshell, which is noticably
slow on cygwin. So please remove them.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6024
