On Thu, 18 Nov 2021 01:34:36 GMT, Stuart Marks <sma...@openjdk.org> wrote:
> Pretty much what it says. The new option controls a static member in > InstanceKlass that's consulted to determine whether the finalization > machinery is activated for instances when a class is loaded. A new native > method is added so that this state can be queried from Java. This is used to > control whether a finalizer thread is created and to disable the `System` and > `Runtime::runFinalization` methods. Includes tests for the above. >From the brief look, it is OK. Minor nits. src/hotspot/share/prims/jvm.cpp line 694: > 692: > 693: JVM_ENTRY(jboolean, JVM_IsFinalizationEnabled(JNIEnv * env)) > 694: return InstanceKlass::finalization_enabled() ? JNI_TRUE : JNI_FALSE; Suggestion: return InstanceKlass::finalization_enabled() ? JNI_TRUE : JNI_FALSE; ------------- PR: https://git.openjdk.java.net/jdk/pull/6442
