On Mon, 22 Nov 2021 09:43:19 GMT, Julia Boes <[email protected]> wrote:
> This change introduces jwebserver, a dedicated JDK tool for the Simple Web
> Server.
>
> A description is provided in a follow-up comment.
src/jdk.httpserver/share/classes/com/sun/net/httpserver/SimpleFileServer.java
line 110:
> 108: *
> 109: * <p>A simple HTTP file server implementation is provided via the
> 110: * {@code jwebserver} tool.
Maybe an `@toolGuide jwebserver` javadoc tag could also be added here too, at
line 111?
src/jdk.httpserver/share/classes/module-info.java line 30:
> 28: * for running a minimal HTTP server.
> 29: *
> 30: * <p>The com.sun.net.httpserver package defines a high-level API for
> building
Maybe that should be "<p> The {@link com.sun.net.httpserver} package defines
..."
src/jdk.httpserver/share/classes/module-info.java line 34:
> 32: * simple HTTP-only file server intended for testing, development and
> debugging
> 33: * purposes. A default implementation is provided via the {@code
> jwebserver} tool
> 34: * and the main entry point of the module, which can be invoked with
should we say "which can also be invoked ..." ?
src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/SimpleFileServerImpl.java
line 74:
> 72: * @param writer the writer to which output should be written
> 73: * @param args the command line options
> 74: * @param launcher the launcher the server is started from
should this be aligned like the other `@param` tags?
src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/resources/simpleserver.properties
line 30:
> 28: \ [-o none|info|verbose] [-h to show options]
> 29:
> 30: usage.jwebserver=\
should usage also show `-version, --version` in both usage strings, and in the
usage summary of the man page below as well?
-------------
PR: https://git.openjdk.java.net/jdk/pull/6497
