On Fri, 3 Dec 2021 03:22:03 GMT, David Holmes <dhol...@openjdk.org> wrote:

>> In JDK-8237858, -pthread was added to all native tests, instead of the one 
>> single test that needed it. In the meantime, two new tests with pthread 
>> dependencies has crept in unnoticed due to this.
>
> Looks good.
> 
> I don't think `-pthread` would actually hurt anything though.
> 
> Thanks,
> David

@dholmes-ora I agree that it's mostly benign in this case, but where do you 
draw the line? For every library you can argue "this does not really hurt to 
include on all tests" and suddenly you have a very complex testing environment 
if all tests have all libraries all the time...

-------------

PR: https://git.openjdk.java.net/jdk/pull/6682

Reply via email to