On Sat, 11 Dec 2021 14:05:12 GMT, Andrew Haley <a...@openjdk.org> wrote:
>> Alan Hayward has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove BSD/Apple specific code > > src/hotspot/cpu/aarch64/globals_aarch64.hpp line 122: > >> 120: "It cannot be used with OnSpinWaitInst=none.") >> \ >> 121: range(1, 99) >> \ >> 122: product(bool, UseROPProtection, false, >> \ > > Question: this is called "UseROPProtection", the configure option is called > "enable-branch-protection", and GCC option is called "-mbranch-protection". > This is confusing. I would have thought we would want the same name, and use > it for all branch protection. So why is this not "UseBranchProtection"? `-mbranch-protection` switches on both PAC-RET and BTI. This PR only covers a use of PAC that looks very ROP-focused to me. ------------- PR: https://git.openjdk.java.net/jdk/pull/6334
