On Wed, 26 Jan 2022 06:23:41 GMT, Thomas Stuefe <stu...@openjdk.org> wrote:
>> After discussing this on hotspot-runtime-dev [1], the general opinion seems >> to be that it would be worthwhile to get rid of INCLUDE_NMT and make NMT >> unconditional. This affects minimal builds only. As pointed out in the mail >> thread, the overhead is very small and it would get rid of one configuration >> to build and test. >> >> [1] >> https://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2022-January/053504.html >> >> Patch removes INCLUDE_NMT from hotspot, as well as dependent macros, as well >> as the associated build option. > > Thomas Stuefe has updated the pull request incrementally with 15 additional > commits since the last revision: > > - 8280377: MethodHandleProxies does not correctly invoke default methods > with varags > > Reviewed-by: alanb > - 8213905: reflection not working for type annotations applied to exception > types in the inner class constructor > > Reviewed-by: jlahoda > - 8279242: Reflection newInstance() error message when constructor has no > access modifiers could use improvement > > Reviewed-by: iris, dholmes, mchung > - 8269542: JDWP: EnableCollection support is no longer spec compliant after > JDK-8255987 > 8258071: Fix for JDK-8255987 can be subverted with > ObjectReference.EnableCollection > > Reviewed-by: dholmes, pliden > - 8280166: Extend java/lang/instrument/GetObjectSizeIntrinsicsTest.java test > cases > > Reviewed-by: sspitsyn, lmesnik > - 8280041: Retry loop issues in java.io.ClassCache > > Co-authored-by: Peter Levart <plev...@openjdk.org> > Reviewed-by: rkennke, rriggs, plevart > - 8280168: Add Objects.toIdentityString > > Reviewed-by: alanb, mchung, rriggs, smarks > - 8279946: (ch) java.nio.channels.FileChannel tryLock and write methods are > missing @throws NonWritableChannelException > > Reviewed-by: alanb > - 8280396: G1: Full gc mark stack draining should prefer to make work > available to other threads > > Reviewed-by: sjohanss, ayang > - 8280414: Memory leak in DefaultProxySelector > > Reviewed-by: dfuchs > - ... and 5 more: > https://git.openjdk.java.net/jdk/compare/a19176e6...44478392 There is some major weirdness in this PR: it includes a lot of unrelated changes. Consider rebasing to current master and force-pushing? ------------- PR: https://git.openjdk.java.net/jdk/pull/7213