On Mon, 7 Mar 2022 14:20:04 GMT, Erik Joelsson <er...@openjdk.org> wrote:

>> Magnus Ihse Bursie has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Test for updated, not current
>
> doc/building.md line 1546:
> 
>> 1544: You must also make sure your build does not rely on `configure`'s 
>> default adhoc
>> 1545: version strings. Default adhoc version strings `OPT` segment include 
>> user name,
>> 1546: source directory and timestamp. You can either override just the `OPT` 
>> segment
> 
> The timestamp comes from Oracle internal builds using Jib. If you just use 
> configure, the default OPT string is `adhoc.<username>.<base dir name>`.
> 
> As a followup on this, I think we should change jib-profiles.js to extract 
> the date from the buildId and set --with-source-date based on it.

Thanks for noticing.

Yes, I have been thinking the same.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7660

Reply via email to