On Tue, 1 Mar 2022 20:18:11 GMT, Man Cao <m...@openjdk.org> wrote: > Hi all, > > Could anyone help review the addition of LICENSE file to hsdis directory? > > -Man
As an engineer and not a lawyer, these are definitely muddy waters to me. I'm trying to get an understanding of the process, but I'm not used to navigating those parts of the organization. But from what I've found out so far, it do seem that if you insist on going through with this, we'd need to get legal approval. Which would be a ton of hassle for me. :( So I implore you to reconsider this PR. And no, hsdis is not the only part of OpenJDK with another license than GPL+CE. The entire hotspot code base, and all tests, are licensed under GPL. But afaic the GPL, GPL+CE and UPL covers all code that is created by the OpenJDK project. This is not a legal guarantee, though, it's just my current understanding of the situation. And thank you for pointing out src/java.desktop/share/native/libsplashscreen/libpng/LICENSE. I'll bring it up with our resident 3rd party license expert. :-) With all that said, if you were to rename the file hsdis-license.txt, I would not have any objection. My sole concern here is that the name "LICENSE" sounds so broad that a lawyer, in the way that lawyers sometime do :), might be able to misinterpret this as applying to anything else than hsdis. With a clearer name, that worry disappears. So if you can accept that name instead, I don't have any more objections. The factual licensing of hsdis under UPL is not in dispute. ------------- PR: https://git.openjdk.java.net/jdk/pull/7649
