On Thu, 17 Mar 2022 11:28:55 GMT, Andrew Leonard <[email protected]> wrote:
>> make/common/JarArchive.gmk line 196:
>>
>>> 194: if [ "`$(WC) -l $$($1_BIN)/_the.$$($1_JARNAME)_contents | $(AWK)
>>> '{ print $$$$1 }'`" -gt "0" ]; then \
>>> 195: $(ECHO) " updating" `$(WC) -l
>>> $$($1_BIN)/_the.$$($1_JARNAME)_contents | $(AWK) '{ print $$$$1 }'` files
>>> && \
>>> 196: $(CAT) $$($1_BIN)/_the.$$($1_JARNAME)_contents | $(SORT) >
>>> $$($1_BIN)/_the.$$($1_JARNAME)_contents_sorted && \
>>
>> I'm very grateful that you found this and fixed it, but this code could
>> really hand you a ["Useless Use of Cat
>> Award"](https://porkmail.org/era/unix/award#cat). :-D
>>
>> `sort in-file > out-file` is much better.
>
> I like to make my mark :-)
> i'm just so used to piping !
Fixed
-------------
PR: https://git.openjdk.java.net/jdk/pull/7852
