On 2022-03-28 09:03, David Holmes wrote:
On 28/03/2022 4:56 pm, Alan Bateman wrote:
On 28/03/2022 07:46, David Holmes wrote:
Hi Jai,
It isn't obvious to me that the bundled sources are actually
intended to build on macOS. There's no include of unistd.h to get
the lseek definition.
I think the context here is that Jai is chasing an issue that may be
bug in the libz on macOS. Building the bundled version and comparing
results would lead to useful information. AFAIK, the system zlib has
always been used since 7u4 when the macOS was added. I think the
Apple JDK did the same. So there may be a small bit of "porting" to
do, adds include files, etc.
Okay, I suggest adding the include of unistd.h as a starter then. But
Jai should note that this is not a build issue per-se - making those
sources buildable on all desired platforms is the job of the owners of
that src in the OpenJDK.
I agree fully, but I'd also like to add that it is not clear that this
is not "supposed" to work. If bundled zlib is not buildable on macOS
(that was news to me), then the correct build system behavior should
have been to block it in configure. So, Jaikiran, if you intend to get
this to work on macOS, great! If you're not taking that route, please
let me know so I can open a bug on prohibiting bundled zlib on maccOS
from configure.
And when getting stuff to compile on new platforms might still require
some assistance and/or interaction with the build group, to get it
right. But, the grunt work lies with the component team, yes.
/Magnus
Cheers,
David
-Alan
