On Tue, 5 Apr 2022 20:57:45 GMT, Christoph Langer <clan...@openjdk.org> wrote:
> Make cygwin usage in GHA more reliable > > With this change we now attempt to retrieve the cygwin installer from cache > every time we need it. > We would also only try to download it once per build job, in the beginning. > During testing we rely on it being cached which will make potential errors > more obvious > (e.g. in the download step in the beginning of the build). > > I also replaced actions/cache@v2 with v3. Didn't see issues. Let's not switch `v2` -> `v3` in this PR. So `windows_aarch64_build`, `windows_x64_build` checks the cache and adds recovery step. But `windows_x64_test` does not do it? Why? If the cygwin installer was cached, it would work fine, but if it does not -- for example if `windows_x64_test` job is restarted in isolation after cache flush -- it would break? I think we should be consistent in this: if installer is not in cache, we always do the recovery. ------------- Changes requested by shade (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/8113
