On Fri, 8 Apr 2022 14:10:05 GMT, Maxim Kartashev <[email protected]> wrote:
>> Andrew Leonard has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Trigger checks
>
> I did some experiments both with `gcc` and `clang`. Both respect the `.file`
> directive and put into the resulting ELF whatever was written after that
> keyword, so no path mapping is necessary. However, debug information suffers
> because `gcc` puts the exact same string into DWARF that debuggers need, so
> writing
>
> .file "linux_x86_64.S"
>
> gives you `DW_AT_NAME("linux_x86_64.S")`, which is not very useful (BTW,
> `clang` accurately points to the absolute path name of the source file) . So
> you have to use the relative path name there:
>
> .file "src/hotspot/os_cpu/linux_x86/linux_x86_64.S"
@mkartashev Why don't you try building with clang as two different users, in
two different directories, and see if the build is non-reproducible without
this patch, but is reproducible with it (incl. your suggested change to include
clang as well)?
-------------
PR: https://git.openjdk.java.net/jdk/pull/8124
