Hi Alan, thanks for the info . Casting to void* first also makes the compile issue go away :
freeze_entry = (address)(void*)freeze<SelectedConfigT>; // If we wanted, we could templatize by kind and have three different thaw entries thaw_entry = (address)(void*)thaw<SelectedConfigT>; >So maybe it time to look at it, it might be easier to have a smaller set >of VS releases to support. On the other hand, having VS2017 for JDK11 - head is rather nice for backporting . Best regards, Matthias -----Original Message----- From: Alan Bateman <alan.bate...@oracle.com> Sent: Tuesday, 10 May 2022 13:16 To: Baesken, Matthias <matthias.baes...@sap.com>; 'build-dev@openjdk.java.net' <build-dev@openjdk.java.net> Cc: Zeller, Arno <arno.zel...@sap.com> Subject: Re: VS2017 build errors jdk/jdk On 10/05/2022 09:29, Baesken, Matthias wrote: > Hello, it seems jdk/jdk does not build any more with VS2017. > Should we still support this compiler ? > > For the error see : > > https://bugs.openjdk.java.net/browse/JDK-8286459 > 8286459: compile error with VS2017 in continuationFreezeThaw.cpp > In Oracle, we moved from using VS2019 16.9.3 to VS2022 17.1.0 a few months ago. I checked the Microsoft site to get the status of VS2017. It says that the "Mainstream End Date" for that release was April 2022 so I guess it's not easy to get updates without extended support now. So maybe it time to look at it, it might be easier to have a smaller set of VS releases to support. -Alan