On Mon, 6 Jun 2022 07:55:09 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> Leo Korinth has updated the pull request incrementally with one additional >> commit since the last revision: >> >> wip > > make/RunTests.gmk line 444: > >> 442: $(strip $(foreach parser,ParseCustomTestSelection >> ParseGtestTestSelection ParseMicroTestSelection ParseJtregTestSelection >> ParseSpecialTestSelection \ >> 443: ,$(call $(parser),$1))) >> 444: endef > > As this is logically a one-liner macro, please format according to > guidelines. Also try to keep lines shortish. Something like this: > > Suggestion: > > ParseTestSelection = \ > $(strip $(foreach parser, ParseCustomTestSelection ParseGtestTestSelection > ParseMicroTestSelection \ > ParseJtregTestSelection ParseSpecialTestSelection, \ > $(call $(parser), $1) \ > )) I made it a one-liner, and I refactored the code to use `or` ------------- PR: https://git.openjdk.java.net/jdk/pull/9028
