Hi George,
On 12/07/2022 6:30 am, George Adams wrote:
Hi all,
I was speaking with Christoph Clanger today about the GitHub actions
rewrite <https://bugs.openjdk.org/browse/JDK-8287906> which has already
made contributing so much simpler.
I wanted to see if there was an interest in switching to using the
actions/setup-java <https://github.com/actions/setup-java> GitHub action
as a way of handling the Boot JDK installation rather than the current
hardcoded URLs defined here
https://github.com/openjdk/jdk/blob/master/make/conf/github-actions.conf#L31-L41
<https://github.com/openjdk/jdk/blob/master/make/conf/github-actions.conf#L31-L41>
If people think this is a good idea then I’ll submit a patch for review
this week.
I don't really see any benefit to doing this, especially when the
existing hardcoded downloads do not even appear to be available via
setup-java. And even if they were we would just replace a fixed known
URL with a fixed known (java-version, distribution) pair of arguments to
setup-java. And setup-java seems to do far more than what we need for
our GHA testing.
Just my 2c.
Cheers,
David
Thanks
George
