On Mon, 25 Jul 2022 17:21:27 GMT, Harold Seigel <hsei...@openjdk.org> wrote:
> Please review this fix for JDK-8285792. The fix removes print statements > from check_signal_handler() so that it doesn't print all the handlers every > time it finds one that is modified. Instead, it returns true if the handler > is modified, false otherwise. Its caller, user_handler(), then prints all > the handlers just once even if multiple signal handlers were modified. > > The fix also adds a check for VMError::crash_handler_adress() to > check_signal_handler() to prevent it from being treated as a signal handler > modification. > > The fix was tested with Mach5 tiers 1-2 on Linux and Mac OS and Mach 5 tiers > 3-5 on Linux x64. The regression test is excluded on Windows. > > Thanks, Harold I ran the test for JDK-8279878 after removing both this fix and the fix for JDK-8279878 and the test still passed. So I don't think its failure was related to this issue. This fix prevents the output from occurring more than once. It does not prevent it from occurring at all. The JVM was reporting that it found an unexpected handler for SIG_IGN. Is it possible that such a handler is no longer being defined? Note that the JVM only checks for unexpected signal handlers if -Xcheck:jni or -XX:+CheckJNICall is specified. ------------- PR: https://git.openjdk.org/jdk/pull/9631
